fix: preserve editor handoff across equivalent Windows paths - #2280
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping a Windows Studio recording can show “Preparing audio does not match this editor's completed sources or output” even though reopening it succeeds. The preparation and editor paths refer to the same folder with different Windows path spellings. Resolve unequal project paths before comparing them in the shared editor handoff used by GPUI and Tauri, while retaining strict track and output identity checks. Also preserve the segment count before transferring sources to finalization, so successful and failed stops both report the recorded segments.
Validation: 87 focused audio/preparation/diagnostic tests passed on macOS, including native rendering of silent one- and two-clip recordings and audio reuse through equivalent editor paths. The path-identity and metadata-save-failure regressions fail before the fix and pass afterward; the failure test also checks that source files remain unchanged. Scoped cargo check, formatting, and diff checks passed. Native Windows and Linux UI replay of the fixed binary remains unverified.
Strict Clippy remains blocked by pre-existing lints in unchanged
preparing_audio/output.rsandrecovery/preparing_projection.rs; no lint errors were reported in changed files.The PR appears safe to merge, with no new actionable findings and the previously reported diagnostic-count issue resolved.
Summary
Reviews (3) · Last reviewed commit: "fix: retain segment diagnostics when fin..."