Skip to content

fix: preserve editor handoff across equivalent Windows paths - #2280

Merged
richiemcilroy merged 3 commits into
mainfrom
fix/windows-editor-handoff-20260912
Sep 12, 2026
Merged

fix: preserve editor handoff across equivalent Windows paths#2280
richiemcilroy merged 3 commits into
mainfrom
fix/windows-editor-handoff-20260912

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 12, 2026

Copy link
Copy Markdown
Member

Stopping a Windows Studio recording can show “Preparing audio does not match this editor's completed sources or output” even though reopening it succeeds. The preparation and editor paths refer to the same folder with different Windows path spellings. Resolve unequal project paths before comparing them in the shared editor handoff used by GPUI and Tauri, while retaining strict track and output identity checks. Also preserve the segment count before transferring sources to finalization, so successful and failed stops both report the recorded segments.

Validation: 87 focused audio/preparation/diagnostic tests passed on macOS, including native rendering of silent one- and two-clip recordings and audio reuse through equivalent editor paths. The path-identity and metadata-save-failure regressions fail before the fix and pass afterward; the failure test also checks that source files remain unchanged. Scoped cargo check, formatting, and diff checks passed. Native Windows and Linux UI replay of the fixed binary remains unverified.

Strict Clippy remains blocked by pre-existing lints in unchanged preparing_audio/output.rs and recovery/preparing_projection.rs; no lint errors were reported in changed files.

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no new actionable findings and the previously reported diagnostic-count issue resolved.

Summary

  • Adds equivalent-path handling and regression coverage for populated and silent audio handoffs.
  • Adds native preview coverage for one- and two-segment silent recordings opened through equivalent paths.
  • Preserves diagnostic segment counts across successful stops and metadata-save failures.

Reviews (3) · Last reviewed commit: "fix: retain segment diagnostics when fin..."

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

Comment thread crates/recording/src/studio_recording.rs Outdated
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit e7ebd94 into main Sep 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant